Re: [PATCH] net/nfp: cast sizeof() to int when comparing with error code

2018-06-25 Thread Jakub Kicinski
On Mon, 25 Jun 2018 15:33:18 +0800, Chengguang Xu wrote: > Negative error code will be larger than sizeof(). > > Signed-off-by: Chengguang Xu You should include the name of the tree in the tag, e.g. [PATCH net] or [PATCH net-next] and if it's a fix, i.e. directed at the net tree, you should add

[PATCH] net/nfp: cast sizeof() to int when comparing with error code

2018-06-25 Thread Chengguang Xu
Negative error code will be larger than sizeof(). Signed-off-by: Chengguang Xu --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c b/drivers/net/ethernet/netronome/nfp