Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-26 Thread Saeed Mahameed
On Tue, Apr 26, 2016 at 6:49 PM, Arnd Bergmann wrote: > On Tuesday 26 April 2016 17:41:45 Saeed Mahameed wrote: >> On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: >> > >> > Sure, do you want to just edit this when you forward the patch, or >> > do you need me to do it? >> > >> >> Well, I wo

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-26 Thread Arnd Bergmann
On Tuesday 26 April 2016 17:41:45 Saeed Mahameed wrote: > On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: > > > > Sure, do you want to just edit this when you forward the patch, or > > do you need me to do it? > > > > Well, I won't say no if you want to do it > All I want is to get rid o

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-26 Thread Saeed Mahameed
On Tue, Apr 26, 2016 at 4:53 PM, Arnd Bergmann wrote: > > Sure, do you want to just edit this when you forward the patch, or > do you need me to do it? > Well, I won't say no if you want to do it :) Saeed

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-26 Thread Arnd Bergmann
On Tuesday 26 April 2016 16:48:33 Saeed Mahameed wrote: > > } > > > > -static void mlx5e_build_channel_param(struct mlx5e_priv *priv, > > - struct mlx5e_channel_param *cparam) > > +static struct mlx5e_channel_param *mlx5e_build_channel_param(struct > > mlx5e_pr

Re: [PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-26 Thread Saeed Mahameed
On Mon, Apr 25, 2016 at 4:15 PM, Arnd Bergmann wrote: > struct mlx5e_channel_param is a large structure that is allocated > on the stack of mlx5e_open_channels, and with a recent change > it has grown beyond the warning size for the maximum stack > that a single function should use: > > mellanox/m

[PATCH] net/mlx5e: avoid stack overflow in mlx5e_open_channels

2016-04-25 Thread Arnd Bergmann
struct mlx5e_channel_param is a large structure that is allocated on the stack of mlx5e_open_channels, and with a recent change it has grown beyond the warning size for the maximum stack that a single function should use: mellanox/mlx5/core/en_main.c: In function 'mlx5e_open_channels': mellanox/ml