Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-08-01 Thread Leon Romanovsky
On Mon, Aug 01, 2016 at 11:11:19AM -0400, Tejun Heo wrote: > > Right now, I'm feeling that I'm participating in soapie where one sends > > patch for every line, waits and sends the same patch for another file. > > It is worth to send one patch set and let us to test it all in once. > > Yeah, I gue

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-08-01 Thread Tejun Heo
Hello, Leon. On Sun, Jul 31, 2016 at 09:35:13AM +0300, Leon Romanovsky wrote: > > The conversion uses WQ_MEM_RECLAIM, which is standard for all > > workqueues which can stall packet processing if stalled. The > > requirement comes from nfs or block devices over network. > > The title stays "remo

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-30 Thread Leon Romanovsky
On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote: > Hello, > > On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > > Did you test this patch? Did you notice the memory reclaim path nature > > of this work? > > The conversion uses WQ_MEM_RECLAIM, which is standard for all >

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
Hello, On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > Did you test this patch? Did you notice the memory reclaim path nature > of this work? The conversion uses WQ_MEM_RECLAIM, which is standard for all workqueues which can stall packet processing if stalled. The requirement

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Saeed Mahameed
On Thu, Jul 28, 2016 at 12:37 PM, Leon Romanovsky wrote: > On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: >> A dedicated workqueue has been used since the work items are being used >> on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward >> progress unde

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Saeed Mahameed
On Thu, Jul 28, 2016 at 11:19 AM, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item. Hence, al

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Leon Romanovsky
On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item. H

[PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-28 Thread Bhaktipriya Shridhar
A dedicated workqueue has been used since the work items are being used on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward progress under memory pressure. The workqueue has a single work item. Hence, alloc_workqueue() is used instead of alloc_ordered_workqueue() since order