Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Qing Huang
Thanks! Looks like Eran's patch will be available much sooner than v4.18 release time frame (since v4.16 was just released). We will wait. :-) On 04/26/2018 04:43 PM, Saeed Mahameed wrote: Before you address my comments, it looks like Eran's work is converging and we will finalize the interna

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Saeed Mahameed
On Thu, Apr 26, 2018 at 4:30 PM, Saeed Mahameed wrote: > On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang wrote: >> >> >> On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >>> >>> On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: Current stats collecting scheme in mlx5 driver is to periodicall

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Saeed Mahameed
On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang wrote: > > > On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >> >> On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: >>> >>> Current stats collecting scheme in mlx5 driver is to periodically fetch >>> aggregated stats from all the active mlx5 software ch

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Qing Huang
On 04/26/2018 02:50 PM, Saeed Mahameed wrote: On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: Current stats collecting scheme in mlx5 driver is to periodically fetch aggregated stats from all the active mlx5 software channels associated with the device. However when a mlx5 interface is bro

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Saeed Mahameed
On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: > Current stats collecting scheme in mlx5 driver is to periodically fetch > aggregated stats from all the active mlx5 software channels associated > with the device. However when a mlx5 interface is brought down(ifdown), > all the channels will be

[PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

2018-04-26 Thread Qing Huang
Current stats collecting scheme in mlx5 driver is to periodically fetch aggregated stats from all the active mlx5 software channels associated with the device. However when a mlx5 interface is brought down(ifdown), all the channels will be deactivated and closed. A new set of channels will be creat