Re: [PATCH] net/mlx5: remove unreachable return

2020-09-22 Thread Pavel Machek
On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > > The last return statement is unreachable code. I'm not sure if it > > > will > > > provoke any warnings, but it looks ugly. >

Re: [PATCH] net/mlx5: remove unreachable return

2020-09-22 Thread Saeed Mahameed
On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > The last return statement is unreachable code. I'm not sure if it > > will > > provoke any warnings, but it looks ugly. > > > > Signed-off-by: Pavel Machek (CIP) > > > > >

Re: [PATCH] net/mlx5: remove unreachable return

2020-09-21 Thread Saeed Mahameed
On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > The last return statement is unreachable code. I'm not sure if it > will > provoke any warnings, but it looks ugly. > > Signed-off-by: Pavel Machek (CIP) > > Applied to net-next-mlx5. Thanks, Saeed.

[PATCH] net/mlx5: remove unreachable return

2020-09-21 Thread Pavel Machek
The last return statement is unreachable code. I'm not sure if it will provoke any warnings, but it looks ugly. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c index 2d55b7c22c03..a804f9