Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-05-04 Thread Leon Romanovsky
On Mon, May 04, 2020 at 05:41:56PM +0200, Arnd Bergmann wrote: > On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky wrote: > > On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote: > > > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > > > > > > While warning limit is generally 1024

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-05-04 Thread Arnd Bergmann
On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky wrote: > On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote: > > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > > > > While warning limit is generally 1024 bytes for 32-bit architectures, > > and 2048 bytes fro 64-bit architectur

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-05-02 Thread Leon Romanovsky
On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote: > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > > On Tue, Apr 28, 2020 at 11:23:47PM +0200, Arnd Bergmann wrote: > > > Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a bit > > > excessive and now causes the

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-04-30 Thread Arnd Bergmann
On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > On Tue, Apr 28, 2020 at 11:23:47PM +0200, Arnd Bergmann wrote: > > Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a bit > > excessive and now causes the compiler to complain on 32-bit architectures: > > > > drivers/net/ethe

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-04-29 Thread Leon Romanovsky
On Tue, Apr 28, 2020 at 11:23:47PM +0200, Arnd Bergmann wrote: > Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a bit > excessive and now causes the compiler to complain on 32-bit architectures: > > drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function > 'qp_read_field':

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-04-28 Thread Saeed Mahameed
On Tue, 2020-04-28 at 23:23 +0200, Arnd Bergmann wrote: > Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a > bit > excessive and now causes the compiler to complain on 32-bit > architectures: > > drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function > 'qp_read_field': >

[PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-04-28 Thread Arnd Bergmann
Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a bit excessive and now causes the compiler to complain on 32-bit architectures: drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function 'qp_read_field': drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:274:1: error: the fram