Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Dan Carpenter
On Mon, Oct 22, 2018 at 09:18:43AM +0300, Or Gerlitz wrote: > On Mon, Oct 22, 2018 at 8:23 AM Dan Carpenter > wrote: > > > > On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > > > I will re-post your patch, this time to netdev since the original > > > commit is there > > > and so shoul

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Or Gerlitz
On Mon, Oct 22, 2018 at 8:23 AM Dan Carpenter wrote: > > On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > > I will re-post your patch, this time to netdev since the original > > commit is there > > and so should be the fix, thanks for reporting/fixing! > > I didn't realize it had been

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Dan Carpenter
On Sun, Oct 21, 2018 at 01:56:26PM +0300, Or Gerlitz wrote: > I will re-post your patch, this time to netdev since the original > commit is there > and so should be the fix, thanks for reporting/fixing! I didn't realize it had been posted to netdev already so I deliberately left that off the CC.

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-21 Thread Or Gerlitz
On Sat, Oct 20, 2018 at 11:37 PM Or Gerlitz wrote: > On Fri, Oct 19, 2018 at 11:08 PM Dan Carpenter > wrote: > > FDB_MAX_CHAIN is 3. We wanted to allocate enough memory to hold four > > structs but there are missing parentheses so we only allocate enough > > memory for three structs and the fir

Re: [PATCH] net/mlx5: allocate enough space in

2018-10-20 Thread Or Gerlitz
On Fri, Oct 19, 2018 at 11:08 PM Dan Carpenter wrote: > > FDB_MAX_CHAIN is 3. We wanted to allocate enough memory to hold four > structs but there are missing parentheses so we only allocate enough > memory for three structs and the first byte of the fourth one. yeah, seems that we were wrong he