Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-28 Thread Patrick McHardy
Denys Vlasenko wrote: On Monday 17 December 2007 14:47, Patrick McHardy wrote: This clashes with my pending patches, which I'll push upstream today. I also spent some time resyncing ip_tables and ip6_tables so a diff of both (with some sed'ing) shows only the actual differences, so please upd

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-26 Thread Denys Vlasenko
On Monday 17 December 2007 14:47, Patrick McHardy wrote: > Please CC netfilter-devel on netfilter patches. > > Denys Vlasenko wrote: > > Hi Patrick, Harald, > > > > I was working on unrelated problem and noticed that ip_tables.c > > seem to abuse inline. I prepared a patch which removes inlines > >

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-17 Thread Patrick McHardy
Please CC netfilter-devel on netfilter patches. Denys Vlasenko wrote: Hi Patrick, Harald, I was working on unrelated problem and noticed that ip_tables.c seem to abuse inline. I prepared a patch which removes inlines except those which are used by packet matching code (and thus are really perfo

[PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-16 Thread Denys Vlasenko
Hi Patrick, Harald, I was working on unrelated problem and noticed that ip_tables.c seem to abuse inline. I prepared a patch which removes inlines except those which are used by packet matching code (and thus are really performance-critical). I added comments explaining that remaining inlines are