Re: [PATCH] net/ethoc: fix null dereference on error exit path

2016-05-22 Thread Colin Ian King
On 22/05/16 20:42, Max Filippov wrote: > Hi Colin, > > On Sun, May 22, 2016 at 08:08:18PM +0100, Colin King wrote: >> From: Colin Ian King >> >> priv is assigned to NULL however all the error exit paths to label 'free' >> dereference priv, causing a null pointer dereference. >> >> Examination of

Re: [PATCH] net/ethoc: fix null dereference on error exit path

2016-05-22 Thread Max Filippov
Hi Colin, On Sun, May 22, 2016 at 08:08:18PM +0100, Colin King wrote: > From: Colin Ian King > > priv is assigned to NULL however all the error exit paths to label 'free' > dereference priv, causing a null pointer dereference. > > Examination of the code shows that all error exits via the 'free

[PATCH] net/ethoc: fix null dereference on error exit path

2016-05-22 Thread Colin King
From: Colin Ian King priv is assigned to NULL however all the error exit paths to label 'free' dereference priv, causing a null pointer dereference. Examination of the code shows that all error exits via the 'free' label path occur before priv is assigned to netdev_priv(netdev), hence there is n