Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-08 Thread David Miller
From: Arnd Bergmann <[EMAIL PROTECTED]> Date: Sun, 7 Oct 2007 02:17:08 +0200 > On Saturday 06 October 2007, Jeff Garzik wrote: > > > > This always bugged me:  dev_ioctl() called dev_ifsioc() either inside > > read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being > > executed. > >

Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Arnd Bergmann
On Saturday 06 October 2007, Jeff Garzik wrote: > > This always bugged me:  dev_ioctl() called dev_ifsioc() either inside > read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being > executed. > > This change moves the ioctls executed inside dev_base_lock to a new > function, dev_ifs

[PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Jeff Garzik
This always bugged me: dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This change moves the ioctls executed inside dev_base_lock to a new function, dev_ifsioc_locked(). Now the locking context is completely clear to