On 03/08/2016 09:38 AM, Dominique Martinet wrote:
> Christoph Hellwig wrote on Thu, Mar 03, 2016:
>> New version with the nits fixed below. Now that checkpath started
>> a stupid warning about not using tabs for indentation which I've
>> ignored here and will take up in my usual fights against Joe
Christoph Hellwig wrote on Thu, Mar 03, 2016:
> New version with the nits fixed below. Now that checkpath started
> a stupid warning about not using tabs for indentation which I've
> ignored here and will take up in my usual fights against Joes
> idicotic opinions separately..
Thanks for the nitp
New version with the nits fixed below. Now that checkpath started
a stupid warning about not using tabs for indentation which I've
ignored here and will take up in my usual fights against Joes
idicotic opinions separately..
--
>From 0055e31f24c7b3642ece5ebb998fa63d772dcb1a Mon Sep 17 00:00:00 200
On Sun, Feb 28, 2016 at 01:03:47PM +0200, Sagi Grimberg wrote:
>
>> Trivial conversion to the new RDMA CQ API.
>
> Looks nice and simple :)
>
> But I think that the fact that CQ processing is now
> done in soft-IRQ (which is an improvement!) needs to
> be documented.
Yeah, I meant to do that, but
Trivial conversion to the new RDMA CQ API.
Looks nice and simple :)
But I think that the fact that CQ processing is now
done in soft-IRQ (which is an improvement!) needs to
be documented.
Other than that, looks great
Reviewed-by: Sagi Grimberg
P.S.
I was also confused in the past about 9p
Hi,
Couple of checkpatch complains:
Christoph Hellwig wrote on Sat, Feb 27, 2016:
> -struct p9_rdma_context {
> - enum ib_wc_opcode wc_op;
> +struct p9_rdma_context {
trailing tab
> - p9_debug(P9_DEBUG_ERROR, "req %p err %d status %d\n", req, err, status);
> + p9_debug(P9_DEBUG
Trivial conversion to the new RDMA CQ API.
Signed-off-by: Christoph Hellwig
---
net/9p/trans_rdma.c | 87 +++--
1 file changed, 31 insertions(+), 56 deletions(-)
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 52b4a2f..668c3be 100644