Re: [PATCH] nedev_rx_csum_fault backtrace unnecessary

2005-12-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 8 Dec 2005 14:58:20 -0800 > The problem I was seeing turned out to be that skb->dev is NULL when > the checksum is being completed in user context. This happens because the > reference to the device is dropped (to allow it to be released when

Re: [PATCH] nedev_rx_csum_fault backtrace unnecessary

2005-12-08 Thread Stephen Hemminger
On Fri, 02 Dec 2005 20:02:10 -0800 (PST) "David S. Miller" <[EMAIL PROTECTED]> wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Sat, 03 Dec 2005 09:59:31 +1100 > > > Sorry but I disagree. First of all this is inside a net_ratelimit() so > > DoS potentials are well, limited :) > > > > More

Re: [PATCH] nedev_rx_csum_fault backtrace unnecessary

2005-12-02 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 03 Dec 2005 09:59:31 +1100 > Sorry but I disagree. First of all this is inside a net_ratelimit() so > DoS potentials are well, limited :) > > More importantly, you should never see this unless there is a hardware > fault or a serious software bug.

Re: [PATCH] nedev_rx_csum_fault backtrace unnecessary

2005-12-02 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The netdev_rx_csum_fault function shouldn't show the stack. The backtrace > can cause way more output than necessary, and could be a potential DoS. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Sorry but I disagree. First of all this is i