Re: [PATCH] natsemi: add checks for dma mapping errors

2015-12-19 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 19 Dec 2015 15:06:45 +0300 > On 19.12.2015 05:36, David Miller wrote: >> From: Alexey Khoroshilov >> Date: Sat, 19 Dec 2015 00:55:37 +0300 >> >>> @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff > *skb, struct net_device *dev) >>> np->tx_s

Re: [PATCH] natsemi: add checks for dma mapping errors

2015-12-19 Thread Alexey Khoroshilov
On 19.12.2015 05:36, David Miller wrote: > From: Alexey Khoroshilov > Date: Sat, 19 Dec 2015 00:55:37 +0300 > >> @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff *skb, struct net_device *dev) >> np->tx_skbuff[entry] = skb; >> np->tx_dma[entry] = pci_map_single(np->pci_de

Re: [PATCH] natsemi: add checks for dma mapping errors

2015-12-18 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 19 Dec 2015 00:55:37 +0300 > @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff *skb, > struct net_device *dev) > np->tx_skbuff[entry] = skb; > np->tx_dma[entry] = pci_map_single(np->pci_dev, > skb->data

[PATCH] natsemi: add checks for dma mapping errors

2015-12-18 Thread Alexey Khoroshilov
refill_rx() and start_tx() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/natsemi.c | 10 ++ 1 file changed, 10