Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-15 Thread Mel Gorman
On Fri, Apr 14, 2017 at 12:10:27PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 10 Apr 2017 14:26:16 -0700 > Andrew Morton wrote: > > > On Mon, 10 Apr 2017 16:08:21 +0100 Mel Gorman > > wrote: > > > > > IRQ context were excluded from using the Per-Cpu-Pages (PCP) lists caching > > > of order

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-14 Thread Jesper Dangaard Brouer
On Mon, 10 Apr 2017 14:26:16 -0700 Andrew Morton wrote: > On Mon, 10 Apr 2017 16:08:21 +0100 Mel Gorman > wrote: > > > IRQ context were excluded from using the Per-Cpu-Pages (PCP) lists caching > > of order-0 pages in commit 374ad05ab64d ("mm, page_alloc: only use per-cpu > > allocator for irq

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-11 Thread Mel Gorman
On Mon, Apr 10, 2017 at 10:53:02PM +0200, Jesper Dangaard Brouer wrote: > > I will appreciate review of this patch. I had reviewed it but didn't have much to say other than the in_interrupt() is inconvenient rather than wrong. > My micro-benchmarking show we > basically return to same page alloc

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-10 Thread Andrew Morton
On Mon, 10 Apr 2017 16:08:21 +0100 Mel Gorman wrote: > IRQ context were excluded from using the Per-Cpu-Pages (PCP) lists caching > of order-0 pages in commit 374ad05ab64d ("mm, page_alloc: only use per-cpu > allocator for irq-safe requests"). > > This unfortunately also included excluded SoftI

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-10 Thread Jesper Dangaard Brouer
I will appreciate review of this patch. My micro-benchmarking show we basically return to same page alloc+free cost as before 374ad05ab64d ("mm, page_alloc: only use per-cpu allocator for irq-safe requests"). Which sort of invalidates this attempt of optimizing the page allocator. But Mel's micro-

[PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

2017-04-10 Thread Mel Gorman
From: Jesper Dangaard Brouer IRQ context were excluded from using the Per-Cpu-Pages (PCP) lists caching of order-0 pages in commit 374ad05ab64d ("mm, page_alloc: only use per-cpu allocator for irq-safe requests"). This unfortunately also included excluded SoftIRQ. This hurt the performance for