Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 12:02:45 +0100 > From: Colin Ian King > > There is an earlier check and return if err is non-zero, so > the check to see if it is zero is redundant in every iteration > of the loop and hence the check can be removed. > > Signed-off-by: Colin Ian King A

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Jiri Pirko
Fri, Sep 23, 2016 at 01:02:45PM CEST, colin.k...@canonical.com wrote: >From: Colin Ian King > >There is an earlier check and return if err is non-zero, so >the check to see if it is zero is redundant in every iteration >of the loop and hence the check can be removed. > >Signed-off-by: Colin Ian Ki

[PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-23 Thread Colin King
From: Colin Ian King There is an earlier check and return if err is non-zero, so the check to see if it is zero is redundant in every iteration of the loop and hence the check can be removed. Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- 1 file change