Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-15 Thread David Miller
From: Jon Mason Date: Mon, 15 May 2017 13:37:09 -0400 > I would prefer #1, as I would not want to break something that was > currently working. However, I think we should add much error logging > here to let people know their DT is hosed (instead of silently > working). So, this would mean appl

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-15 Thread Jon Mason
On Fri, May 12, 2017 at 6:52 PM, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: >> From: Julia Lawall >> Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) >> >>> Device node iterators put the previous value of the index variable, so an >>> explicit put causes a double put. >> ..

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: > > From: Julia Lawall > > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > > > >> Device node iterators put the previous value of the index variable, so an > >> explicit put causes a double put. > > ... >

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Florian Fainelli
On 05/12/2017 09:22 AM, David Miller wrote: > From: Julia Lawall > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > >> Device node iterators put the previous value of the index variable, so an >> explicit put causes a double put. > ... >> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, >>

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread David Miller
From: Julia Lawall Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > Device node iterators put the previous value of the index variable, so an > explicit put causes a double put. ... > @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, > if (r) { > mdiobus_

[PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Julia Lawall
Device node iterators put the previous value of the index variable, so an explicit put causes a double put. In particular, of_mdiobus_register can fail before doing anything interesting, so one could view it as a no-op from the reference count point of view. Generated by: scripts/coccinelle/itera