Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread Stephen Rothwell
Hi Dave, On Mon, 18 Apr 2016 12:43:16 -0400 (EDT) David Miller wrote: > > From: Herbert Xu > Date: Mon, 18 Apr 2016 18:43:36 +0800 > > > Right, the problem is that nothing within crypto ever selects > > CRYPTO since it's also used as a way of hiding the crypto menu > > options. > > As far a

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread David Miller
From: Herbert Xu Date: Mon, 18 Apr 2016 18:43:36 +0800 > Right, the problem is that nothing within crypto ever selects > CRYPTO since it's also used as a way of hiding the crypto menu > options. As far as I understand it, this won't help. Because selects do not trigger other selects and depende

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread David Miller
From: Herbert Xu Date: Mon, 18 Apr 2016 16:02:02 +0800 > In fact this strikes me as a kbuild bug because CRYPTO_GCM already > selects (indirectly) CRYPTO_ALGAPI so why is this happening at all? Selects don't trigger selects.

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 18:43:36 Herbert Xu wrote: > > It's kind of silly really now that IPv4 selects CRYPTO which > means that you can't really avoid seeing all those options which > most users won't care about. I had not noticed that IPv4 does it, but that is a good point. We have had a coupl

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread Herbert Xu
On Mon, Apr 18, 2016 at 12:23:42PM +0200, Arnd Bergmann wrote: > > No, that is not the problem. > > These are the options from the randconfig file that showed the error: > > # CONFIG_MODULES is not set > # CONFIG_CRYPTO is not set > CONFIG_CRYPTO_GCM=y > CONFIG_CRYPTO_AES=y > CONFIG_MACSEC=y > #

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 16:02:02 Herbert Xu wrote: > Arnd Bergmann wrote: > > The new MACsec driver uses the AES crypto algorithm, but can be configured > > even if CONFIG_CRYPTO is disabled, leading to a build error: > > > > warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-18 Thread Herbert Xu
Arnd Bergmann wrote: > The new MACsec driver uses the AES crypto algorithm, but can be configured > even if CONFIG_CRYPTO is disabled, leading to a build error: > > warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct > dependencies (CRYPTO) > warning: (BT && CEPH_LIB && INET

Re: [PATCH] macsec: fix crypto Kconfig dependency

2016-04-17 Thread David Miller
From: Arnd Bergmann Date: Sun, 17 Apr 2016 11:19:55 +0200 > The new MACsec driver uses the AES crypto algorithm, but can be configured > even if CONFIG_CRYPTO is disabled, leading to a build error: > > warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct > dependencies (CRYPT

[PATCH] macsec: fix crypto Kconfig dependency

2016-04-17 Thread Arnd Bergmann
The new MACsec driver uses the AES crypto algorithm, but can be configured even if CONFIG_CRYPTO is disabled, leading to a build error: warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct dependencies (CRYPTO) warning: (BT && CEPH_LIB && INET && MAC802154 && MAC80211 && BLK_DE