Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-16 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 9/13/19 8:53 PM, Yonghong Song wrote: >> On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: >>> Yonghong Song writes: On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: > The xsk_socket__create() function fails and returns an error if it cannot > get the

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-16 Thread Daniel Borkmann
On 9/13/19 8:53 PM, Yonghong Song wrote: On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: Yonghong Song writes: On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: The xsk_socket__create() function fails and returns an error if it cannot get the XDP_OPTIONS through getsockopt(). However, supp

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-15 Thread Björn Töpel
On Fri, 13 Sep 2019 at 21:46, Yonghong Song wrote: > > > > On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: > > Yonghong Song writes: > > > >> On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: > >>> The xsk_socket__create() function fails and returns an error if it cannot > >>> get the XDP_OPTI

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-13 Thread Yonghong Song
On 9/10/19 12:06 AM, Toke Høiland-Jørgensen wrote: > Yonghong Song writes: > >> On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: >>> The xsk_socket__create() function fails and returns an error if it cannot >>> get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS >>> was

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-09 Thread Toke Høiland-Jørgensen
Yonghong Song writes: > On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: >> The xsk_socket__create() function fails and returns an error if it cannot >> get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS >> was not added until kernel 5.3, so this means that creating XSK s

Re: [PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-09 Thread Yonghong Song
On 9/9/19 10:46 AM, Toke Høiland-Jørgensen wrote: > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets > always fails on ol

[PATCH] libbpf: Don't error out if getsockopt() fails for XDP_OPTIONS

2019-09-09 Thread Toke Høiland-Jørgensen
The xsk_socket__create() function fails and returns an error if it cannot get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS was not added until kernel 5.3, so this means that creating XSK sockets always fails on older kernels. Since the option is just used to set the zero-