Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jeff Kirsher
On Thu, 2019-09-12 at 11:33 -0500, Jonathan Tooker wrote: > On 9/12/2019 6:01 AM, Steffen Klassert wrote: > > The ixgbe driver currently does IPsec TX offloading > > based on an existing secpath. However, the secpath > > can also come from the RX side, in this case it is > > misinterpreted for TX o

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Shannon Nelson
On 9/12/19 5:33 PM, Jonathan Tooker wrote: On 9/12/2019 6:01 AM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dro

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Michael Marley
On 2019-09-12 07:01, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by u

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Shannon Nelson
On 9/12/19 12:01 PM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by u

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jonathan Tooker
On 9/12/2019 6:01 AM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jeff Kirsher
On Thu, 2019-09-12 at 13:43 +0200, David Miller wrote: > From: Steffen Klassert > Date: Thu, 12 Sep 2019 13:01:44 +0200 > > > The ixgbe driver currently does IPsec TX offloading > > based on an existing secpath. However, the secpath > > can also come from the RX side, in this case it is > > misin

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread David Miller
From: Steffen Klassert Date: Thu, 12 Sep 2019 13:01:44 +0200 > The ixgbe driver currently does IPsec TX offloading > based on an existing secpath. However, the secpath > can also come from the RX side, in this case it is > misinterpreted for TX offload and the packets are > dropped with a "bad sa

[PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Steffen Klassert
The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by using the xfrm_offload() function to test for TX