Re: [PATCH] irlan: fix header build warning

2006-12-06 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Wed, 6 Dec 2006 17:08:18 -0800 > On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote: > > > How about we protect these function externs with CONFIG_PROC_FS ifdefs > > instead? > > Sure. > > --- > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fi

Re: [PATCH] irlan: fix header build warning

2006-12-06 Thread Randy Dunlap
On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote: > How about we protect these function externs with CONFIG_PROC_FS ifdefs > instead? Sure. --- From: Randy Dunlap <[EMAIL PROTECTED]> Fix compile warning when CONFIG_PROC_FS=n: include/net/irda/irlan_filter.h:31: warning: 'struct seq_

Re: [PATCH] irlan: fix header build warning

2006-12-06 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Wed, 6 Dec 2006 11:44:07 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix compile warning when CONFIG_PROC_FS=n: > > include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared > inside parameter list > include/net/irda/irlan_filter

Re: [PATCH] irlan: fix header build warning

2006-12-06 Thread Samuel Ortiz
Hi Randy, Thanks for the patch. Looks fine to me. On Wed, Dec 06, 2006 at 11:44:07AM -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix compile warning when CONFIG_PROC_FS=n: > > include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared > inside parameter

[PATCH] irlan: fix header build warning

2006-12-06 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix compile warning when CONFIG_PROC_FS=n: include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not wh