Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-08 Thread Krzysztof Oledzki
On Fri, 8 Feb 2008, Andi Kleen wrote: Sven Wegener <[EMAIL PROTECTED]> writes: The default synchronization interval of 1000 milliseconds is too high for a heavily loaded director. Collecting the connection information from one second and then sending it out in a burst will overflow the socke

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-08 Thread Andi Kleen
Sven Wegener <[EMAIL PROTECTED]> writes: > The default synchronization interval of 1000 milliseconds is too high for a > heavily loaded director. Collecting the connection information from one second > and then sending it out in a burst will overflow the socket buffer and lead to > synchronization

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread David Rientjes
On Thu, 7 Feb 2008, Sven Wegener wrote: > Negative values will be converted to MAX_JIFFY_OFFSET by msecs_to_jiffies and > result in a very long interval. A too long interval will be a good way to get > your system OOM. We could use an unsigned int or even restrict the value with > proc_dointvec_mi

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Simon Horman
On Thu, Feb 07, 2008 at 12:57:43AM +0100, Sven Wegener wrote: > The default synchronization interval of 1000 milliseconds is too high for a > heavily loaded director. Collecting the connection information from one second > and then sending it out in a burst will overflow the socket buffer and lead

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
The default synchronization interval of 1000 milliseconds is too high for a heavily loaded director. Collecting the connection information from one second and then sending it out in a burst will overflow the socket buffer and lead to synchronization information being dropped. Make the interval cont

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
On Wed, 6 Feb 2008, David Rientjes wrote: On Wed, 6 Feb 2008, Sven Wegener wrote: diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c index 948378d..9b57ad3 100644 --- a/net/ipv4/ipvs/ip_vs_sync.c +++ b/net/ipv4/ipvs/ip_vs_sync.c @@ -143,6 +143,8 @@ char ip_vs_backup_mcast_ifn

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread David Rientjes
On Wed, 6 Feb 2008, Sven Wegener wrote: > diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c > index 948378d..9b57ad3 100644 > --- a/net/ipv4/ipvs/ip_vs_sync.c > +++ b/net/ipv4/ipvs/ip_vs_sync.c > @@ -143,6 +143,8 @@ char ip_vs_backup_mcast_ifn[IP_VS_IFNAME_MAXLEN]; > /* multica

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
The default synchronization interval of 1000 milliseconds is too high for a heavily loaded director. Collecting the connection information from one second and then sending it out in a burst will overflow the socket buffer and lead to synchronization information being dropped. Make the interval cont