Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-19 Thread David Miller
From: Jiri Bohac Date: Wed, 19 Oct 2016 15:16:36 +0200 > The purpose was to guard against the user updating the > temp_prefered_lft sysctl after this: > > max_desync_factor = min_t(__u32, > idev->cnf.max_desync_factor, >

Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-19 Thread Jiri Bohac
Hi, On Tue, Oct 18, 2016 at 02:25:25PM -0400, David Miller wrote: > Does the check make any sense at all? I'd say just remove it. The purpose was to guard against the user updating the temp_prefered_lft sysctl after this: max_desync_factor = min_t(__u32,

Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-18 Thread David Miller
From: Jiri Bohac Date: Tue, 18 Oct 2016 17:01:54 +0200 > Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix > DESYNC_FACTOR) introduced a buggy check for underflow of > tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition > is always false. > > Signed-off-by: Jiri Bohac > Re

[PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-18 Thread Jiri Bohac
Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix DESYNC_FACTOR) introduced a buggy check for underflow of tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition is always false. Signed-off-by: Jiri Bohac Reported-by: Julia Lawall Fixes: 76506a986dc3 ("IPv6: fix DESYNC_FACTOR"