Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-07 Thread Nikolay Aleksandrov
On 03/06/2020 00:01, David Miller wrote: > From: Nikolay Aleksandrov > Date: Tue, 2 Jun 2020 10:23:09 +0300 > >> On 01/06/2020 21:06, David Miller wrote: >>> From: patrickeigens...@gmail.com >>> Date: Mon, 1 Jun 2020 13:12:01 +0200 >>> From: Patrick Eigensatz After allocating the

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 2 Jun 2020 10:23:09 +0300 > On 01/06/2020 21:06, David Miller wrote: >> From: patrickeigens...@gmail.com >> Date: Mon, 1 Jun 2020 13:12:01 +0200 >> >>> From: Patrick Eigensatz >>> >>> After allocating the spare nexthop group it should be tested for kzalloc(

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread Nikolay Aleksandrov
On 02/06/2020 10:23, Nikolay Aleksandrov wrote: > On 01/06/2020 21:06, David Miller wrote: >> From: patrickeigens...@gmail.com >> Date: Mon, 1 Jun 2020 13:12:01 +0200 >> >>> From: Patrick Eigensatz >>> >>> After allocating the spare nexthop group it should be tested for kzalloc() >>> returning NU

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread Nikolay Aleksandrov
On 01/06/2020 21:06, David Miller wrote: > From: patrickeigens...@gmail.com > Date: Mon, 1 Jun 2020 13:12:01 +0200 > >> From: Patrick Eigensatz >> >> After allocating the spare nexthop group it should be tested for kzalloc() >> returning NULL, instead the already used nexthop group (which cannot

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread David Miller
From: patrickeigens...@gmail.com Date: Mon, 1 Jun 2020 13:12:01 +0200 > From: Patrick Eigensatz > > After allocating the spare nexthop group it should be tested for kzalloc() > returning NULL, instead the already used nexthop group (which cannot be > NULL at this point) had been tested so far.

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread Nikolay Aleksandrov
On 01/06/2020 14:12, patrickeigens...@gmail.com wrote: > From: Patrick Eigensatz > > After allocating the spare nexthop group it should be tested for kzalloc() > returning NULL, instead the already used nexthop group (which cannot be > NULL at this point) had been tested so far. > > Additionally

[PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread patrickeigensatz
From: Patrick Eigensatz After allocating the spare nexthop group it should be tested for kzalloc() returning NULL, instead the already used nexthop group (which cannot be NULL at this point) had been tested so far. Additionally, if kzalloc() fails, return ERR_PTR(-ENOMEM) instead of NULL. Cover