Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-14 Thread 严海双
> On 14 Jun 2017, at 1:28 PM, Peter Dawson wrote: > > On Wed, 14 Jun 2017 10:54:31 +0800 > 严海双 wrote: > > >>> Changes since v2: >>> * mask key->tos with RT_TOS() suggested by Daniel > > Can you help me understand the rationale for this change? Is there are bug > introduced by dsfield = ip6_

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Peter Dawson
On Wed, 14 Jun 2017 10:54:31 +0800 严海双 wrote: > > Changes since v2: > > * mask key->tos with RT_TOS() suggested by Daniel Can you help me understand the rationale for this change? Is there are bug introduced by dsfield = ip6_tclass(key->label); ? The RT_TOS masks out 4bits of the 8bit tos fi

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread 严海双
> On 14 Jun 2017, at 10:48 AM, Haishuang Yan > wrote: > > Same as ip_gre, geneve and vxlan, use key->tos as tos value. > > CC: Peter Dawson > Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on > encapsulated packets”) > Suggested-by: Daniel Borkmann > Signed-off-by: Haishuang

[PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Haishuang Yan
Same as ip_gre, geneve and vxlan, use key->tos as tos value. CC: Peter Dawson Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets”) Suggested-by: Daniel Borkmann Signed-off-by: Haishuang Yan --- Changes since v2: * Add fixes information * mask key->tos wi

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Daniel Borkmann
On 06/13/2017 03:31 PM, 严海双 wrote: On 13 Jun 2017, at 5:57 PM, Daniel Borkmann wrote: On 06/13/2017 09:55 AM, Haishuang Yan wrote: Same as ip_gre, geneve and vxlan, use key->tos as tos value. Please also add Fixes tag and Cc original authors. Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix se

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Daniel Borkmann
On 06/13/2017 09:55 AM, Haishuang Yan wrote: Same as ip_gre, geneve and vxlan, use key->tos as tos value. Please also add Fixes tag and Cc original authors. Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets") Signed-off-by: Haishuang Yan --- net/ipv6

[PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Haishuang Yan
Same as ip_gre, geneve and vxlan, use key->tos as tos value. Signed-off-by: Haishuang Yan --- net/ipv6/ip6_tunnel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index ef99d59..5f4aff5 100644 --- a/net/ipv6/ip6_tunnel.c +++