Re: [PATCH] ip[6]_tables.c: remove some inlines

2008-01-08 Thread Patrick McHardy
Denys Vlasenko wrote: On Monday 31 December 2007 17:00, Patrick McHardy wrote: Denys Vlasenko wrote: ip[6]_tables.c seem to abuse inline. This patch removes inlines except those which are used by packet matching code and thus are performance-critical. Some people also consider the ruleset

Re: [PATCH] ip[6]_tables.c: remove some inlines

2007-12-31 Thread Denys Vlasenko
On Monday 31 December 2007 17:00, Patrick McHardy wrote: > Denys Vlasenko wrote: > > ip[6]_tables.c seem to abuse inline. > > > > This patch removes inlines except those which are used > > by packet matching code and thus are performance-critical. > > > > Some people also consider the ruleset r

Re: [PATCH] ip[6]_tables.c: remove some inlines

2007-12-31 Thread Patrick McHardy
Denys Vlasenko wrote: ip[6]_tables.c seem to abuse inline. This patch removes inlines except those which are used by packet matching code and thus are performance-critical. Some people also consider the ruleset replacement path performance critical, but overall I agree with your patch. I'm

[PATCH] ip[6]_tables.c: remove some inlines

2007-12-31 Thread Denys Vlasenko
On Friday 28 December 2007 15:30, Patrick McHardy wrote: > >> This clashes with my pending patches, which I'll push upstream > >> today. I also spent some time resyncing ip_tables and ip6_tables > >> so a diff of both (with some sed'ing) shows only the actual > >> differences, so please update ip6_