Re: [PATCH] ioctl: only memset non-NULL link settings

2020-08-27 Thread Hans-Christian Egtvedt (hegtvedt)
On 27/08/2020 10:23, Michal Kubecek wrote: > On Mon, Aug 24, 2020 at 08:46:30AM +0200, Hans-Christian Noren Egtvedt wrote: >> In commit bef780467fa ('ioctl: do not pass transceiver value back to >> kernel') a regression slipped. If we have a kernel that does not support >> the ETHTOOL_xLINKSETTINGS

Re: [PATCH] ioctl: only memset non-NULL link settings

2020-08-27 Thread Michal Kubecek
On Mon, Aug 24, 2020 at 08:46:30AM +0200, Hans-Christian Noren Egtvedt wrote: > In commit bef780467fa ('ioctl: do not pass transceiver value back to > kernel') a regression slipped. If we have a kernel that does not support > the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() > functi

[PATCH] ioctl: only memset non-NULL link settings

2020-08-23 Thread Hans-Christian Noren Egtvedt
In commit bef780467fa ('ioctl: do not pass transceiver value back to kernel') a regression slipped. If we have a kernel that does not support the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() function will return a NULL pointer. Hence before memset'ing the pointer to zero we must fi