Re: [PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread Weongyo Jeong
On 03/09/2016 12:37 PM, David Miller wrote: From: Weongyo Jeong Date: Wed, 9 Mar 2016 10:22:21 -0800 A trivial patch to set `error' variable while not holding lock_sock(). Signed-off-by: Weongyo Jeong Deferring the assignment means gcc doesn't have to potentially put it on the stack across

Re: [PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread David Miller
From: Weongyo Jeong Date: Wed, 9 Mar 2016 10:22:21 -0800 > A trivial patch to set `error' variable while not holding > lock_sock(). > > Signed-off-by: Weongyo Jeong Deferring the assignment means gcc doesn't have to potentially put it on the stack across the lock_sock() call. You're making th

[PATCH] inet: set `error' value not under lock_sock().

2016-03-09 Thread Weongyo Jeong
A trivial patch to set `error' variable while not holding lock_sock(). Signed-off-by: Weongyo Jeong --- net/ipv4/inet_connection_sock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 6414891..58bc39f 1