Re: [PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Vegard Nossum
On 12/17/2015 02:01 AM, Eric Dumazet wrote: On Wed, Dec 16, 2015 at 4:57 PM, Vegard Nossum wrote: If you create a raw socket with a protocol of e.g. 0x1, then inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 bits. This causes problems further down the line as lots of co

Re: [PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Eric Dumazet
On Wed, Dec 16, 2015 at 4:57 PM, Vegard Nossum wrote: > If you create a raw socket with a protocol of e.g. 0x1, then > inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 > bits. This causes problems further down the line as lots of code makes > assumptions about ->inet_num,

[PATCH] inet: sanitize socket() protocol value

2015-12-16 Thread Vegard Nossum
If you create a raw socket with a protocol of e.g. 0x1, then inet_sk(sk)->inet_num will get set to 0 since it only has room for 16 bits. This causes problems further down the line as lots of code makes assumptions about ->inet_num, for example connect()...inet_autobind() will attempt to call sk