RE: [PATCH] igb: avoid premature Rx buffer reuse

2021-03-12 Thread Jambekar, Vishakha
> From: Intel-wired-lan On Behalf Of > Li,Rongqing > Sent: Tuesday, January 12, 2021 8:24 AM > To: Alexander Duyck > Cc: Netdev ; Topel, Bjorn ; > intel-wired-lan > Subject: Re: [Intel-wired-lan] [PATCH] igb: avoid premature Rx buffer reuse > > > > >

RE: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-12 Thread Li,Rongqing
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, January 13, 2021 5:23 AM > To: Li,Rongqing > Cc: Netdev ; intel-wired-lan > ; Björn Töpel > Subject: Re: [PATCH] igb: avoid premature Rx buffer r > Okay, this explanation makes much more

Re: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-12 Thread Alexander Duyck
; ; Björn Töpel > > Subject: Re: [PATCH] igb: avoid premature Rx buffer reuse > > > > On Wed, Jan 6, 2021 at 7:53 PM Li RongQing wrote: > > > > > > The page recycle code, incorrectly, relied on that a page fragment > > > could not be freed inside xdp_do

RE: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-11 Thread Li,Rongqing
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Tuesday, January 12, 2021 4:54 AM > To: Li,Rongqing > Cc: Netdev ; intel-wired-lan > ; Björn Töpel > Subject: Re: [PATCH] igb: avoid premature Rx buffer reuse > > On Wed

Re: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-11 Thread Alexander Duyck
On Wed, Jan 6, 2021 at 7:53 PM Li RongQing wrote: > > The page recycle code, incorrectly, relied on that a page fragment > could not be freed inside xdp_do_redirect(). This assumption leads to > that page fragments that are used by the stack/XDP redirect can be > reused and overwritten. > > To avo

[PATCH] igb: avoid premature Rx buffer reuse

2021-01-06 Thread Li RongQing
The page recycle code, incorrectly, relied on that a page fragment could not be freed inside xdp_do_redirect(). This assumption leads to that page fragments that are used by the stack/XDP redirect can be reused and overwritten. To avoid this, store the page count prior invoking xdp_do_redirect().