Re: [Intel-wired-lan] [PATCH] i40evf: remove redundant null check on key

On Sat, Jun 10, 2017 at 4:33 AM, Dan Carpenter wrote: > > This patch isn't right... > > On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote: >> From: Colin Ian King >> >> key has previously been null checked so the subsequent null check >> is redundant as key can never be null at that poin

Re: [PATCH] i40evf: remove redundant null check on key

This patch isn't right... On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote: > From: Colin Ian King > > key has previously been null checked so the subsequent null check > is redundant as key can never be null at that point, so remove it. > Actually, it's the reverse. "key" is alway

[PATCH] i40evf: remove redundant null check on key

From: Colin Ian King key has previously been null checked so the subsequent null check is redundant as key can never be null at that point, so remove it. Detected by CoverityScan, CID#1357164 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/net/ethernet/intel/i40evf/i40evf_et