Re: [PATCH] gfs2: Stop using rhashtable_walk_peek

2018-03-28 Thread Andreas Gruenbacher
On 28 March 2018 at 23:53, NeilBrown wrote: > Thank for this patch! > The above looks a bit fragile to me. > gfs2_glock_iter_next() (And hence gfs2_glock_seq_start()) will sometimes > exit with gl_held true, and sometimes with it false. > gfs2_glock_seq_stop() assumes that it is false. > Normally

Re: [PATCH] gfs2: Stop using rhashtable_walk_peek

2018-03-28 Thread NeilBrown
On Wed, Mar 28 2018, Andreas Gruenbacher wrote: > Function rhashtable_walk_peek is problematic because there is no > guarantee that the glock previously returned still exists; when that key > is deleted, rhashtable_walk_peek can end up returning a different key, > which would cause an inconsistent

[PATCH] gfs2: Stop using rhashtable_walk_peek

2018-03-28 Thread Andreas Gruenbacher
Function rhashtable_walk_peek is problematic because there is no guarantee that the glock previously returned still exists; when that key is deleted, rhashtable_walk_peek can end up returning a different key, which would cause an inconsistent glock dump. So instead of using rhashtable_walk_peek, k