Re: [PATCH] forcedeth: TSO fix for large buffers

Manfred Spraul <[EMAIL PROTECTED]> wrote: > > This patch contains a bug fix for large buffers. Originally, if a tx > buffer to be sent was larger then the maximum size of the tx descriptor, > > it would overwrite other control bits. In this patch, the buffer is > split over multiple descripto

Re: [PATCH] forcedeth: TSO fix for large buffers

If you look at the code, I do not set the NV_TX2_VALID bit (stored in np->tx_flags) in the first tx descriptor until all other descriptors for this transmit are setup. This ensures hardware will not look at it. Once all fragments/descriptors are setup, I setup the control bits for the first tx

Re: [PATCH] forcedeth: TSO fix for large buffers

Ayaz Abdulla wrote: If you look at the code, I do not set the NV_TX2_VALID bit (stored in np->tx_flags) in the first tx descriptor You are right: tx_flags starts as 0 and is only set to np->tx_flags after the first tx descriptor was set up. I overlooked that point, sorry. Jeff: Could you ad

Re: [PATCH] forcedeth: TSO fix for large buffers

From: Manfred Spraul <[EMAIL PROTECTED]> Date: Sun, 25 Dec 2005 15:51:42 +0100 > This patch contains a bug fix for large buffers. Originally, if a tx > buffer to be sent was larger then the maximum size of the tx descriptor, > > it would overwrite other control bits. In this patch, the buffer is

[PATCH] forcedeth: TSO fix for large buffers

This patch contains a bug fix for large buffers. Originally, if a tx buffer to be sent was larger then the maximum size of the tx descriptor, it would overwrite other control bits. In this patch, the buffer is split over multiple descriptors. Also, the fragments are now setup in forward order.

Re: [PATCH] forcedeth TSO fix for large buffers

Has anyone had a chance to review this patch and apply it? I would like it to make 2.6.15 kernel since it is a bug related to TSO in the driver. Thanks, Ayaz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] forcedeth TSO fix for large buffers

This patch contains a bug fix for large buffers. Originally, if a tx buffer to be sent was larger then the maximum size of the tx descriptor, it would overwrite other control bits. In this patch, the buffer is split over multiple descriptors. Also, the fragments are now setup in forward order.