Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 13 Aug 2006 20:49:06 +0200 > Andrew Morton wrote: > > On Sun, 13 Aug 2006 13:52:58 +0200 > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > >>Quite a few users of netlink_kernel_create will panic when creating > >>the socket fails (rtnetlink

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Patrick McHardy
Andrew Morton wrote: > On Sun, 13 Aug 2006 13:52:58 +0200 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > >>Quite a few users of netlink_kernel_create will panic when creating >>the socket fails (rtnetlink for example, which is always present), >>so you might as well call panic here directly. > >

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Andrew Morton
On Sun, 13 Aug 2006 13:52:58 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Akinobu Mita wrote: > > This patch invalidates nl_table by setting NULL when netlink > > initialization failed. Otherwise netlink_kernel_create() would > > access nl_table which has already been freed. > > > Quite a

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Patrick McHardy
Akinobu Mita wrote: > This patch invalidates nl_table by setting NULL when netlink > initialization failed. Otherwise netlink_kernel_create() would > access nl_table which has already been freed. Quite a few users of netlink_kernel_create will panic when creating the socket fails (rtnetlink for e

[PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Akinobu Mita
This patch invalidates nl_table by setting NULL when netlink initialization failed. Otherwise netlink_kernel_create() would access nl_table which has already been freed. CC: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> net/netlink/af_netlink.c | 11