Re: [PATCH] fix limited slow start bug

2007-02-25 Thread Arnaldo Carvalho de Melo
On 2/25/07, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: On 2/25/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Roger While <[EMAIL PROTECTED]> > Date: Sun, 25 Feb 2007 09:55:34 +0100 > > > Was anything done about size/member alignment of struct tcp_sock per > > mail from last year -

Re: [PATCH] fix limited slow start bug

2007-02-25 Thread Arnaldo Carvalho de Melo
On 2/25/07, David Miller <[EMAIL PROTECTED]> wrote: From: Roger While <[EMAIL PROTECTED]> Date: Sun, 25 Feb 2007 09:55:34 +0100 > Was anything done about size/member alignment of struct tcp_sock per > mail from last year - > http://marc.theaimsgroup.com/?l=linux-netdev&m=114318857102290&w=2 > >

Re: [PATCH] fix limited slow start bug

2007-02-25 Thread David Miller
From: Roger While <[EMAIL PROTECTED]> Date: Sun, 25 Feb 2007 09:55:34 +0100 > Was anything done about size/member alignment of struct tcp_sock per > mail from last year - > http://marc.theaimsgroup.com/?l=linux-netdev&m=114318857102290&w=2 > > (I have no idea what current size is) Nothing has b

Re: [PATCH] fix limited slow start bug

2007-02-25 Thread Roger While
Dave M wrote : diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 415193e..18a468d 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -302,7 +302,7 @@ struct tcp_sock { u32 snd_ssthresh; /* Slow start size threshold*/ u32 snd_cwnd;

Re: [PATCH] fix limited slow start bug

2007-02-22 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2007 16:52:03 -0500 > I think it's not unreasonable to change clamp to 32 bits now, since with > 1500 byte packets, this corresponds to a max cwnd of ~94MB. This is > pretty big, but we are currently right at this limit with 10 GigE. Agr

Re: [PATCH] fix limited slow start bug

2007-02-22 Thread David Miller
John, what tree did you diff this against? I can tell you didn't create this patch against anything actually in any of my trees, because: diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c index 7fd2910..a0c894f 100644 --- a/net/ipv4/tcp_cong.c +++ b/net/ipv4/tcp_cong.c @@ -303,9 +303,9 @@ v

Re: [PATCH] fix limited slow start bug

2007-02-22 Thread John Heffner
Ilpo Järvinen wrote: BTW, while looking this patch, I noticed that snd_cwnd_clamp is only u16 while snd_cwnd is u32, which seems rather strange since snd_cwnd is being limited by the clamp value here and there?!?! And tcp_highspeed.c is clearly assuming even more than this (but the problem is h

Re: [PATCH] fix limited slow start bug

2007-02-22 Thread Ilpo Järvinen
On Thu, 22 Feb 2007, John Heffner wrote: > diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c > index 7fd2910..a0c894f 100644 > --- a/net/ipv4/tcp_cong.c > +++ b/net/ipv4/tcp_cong.c > @@ -303,9 +303,9 @@ void tcp_slow_start(struct tcp_sock *tp) > > tp->snd_cwnd_cnt += cnt; >

[PATCH] fix limited slow start bug

2007-02-22 Thread John Heffner
Fix arithmetic order bug in limited slow start. The subtraction needs to be done before snd_cwnd is incremented. Signed-off-by: John Heffner <[EMAIL PROTECTED]> --- commit 244e7411d99443df7b7ae849ba6ebbec4c2342bc tree e6d5985a22448f59f8bef393542e1d5497ee5684 parent 97033fa201705e6cfc68ce66f34ed