Re: [PATCH] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 4:14 PM Nathan Chancellor wrote: > > A slightly less intrusive change would be using cpumask_available, which > was specifically introduced for this purpose in commit f7e30f01a9e2 > ("cpumask: Add helper cpumask_available()"). Ah nice, I wasn't aware of that function. I'll

Re: [PATCH] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 10:33:02AM +0100, Arnd Bergmann wrote: > The enic driver relies on the CONFIG_CPUMASK_OFFSTACK feature to > dynamically allocate a struct member, but this is normally intended for > local variables. > > Building with clang, I get a warning for a few locations that check the

[PATCH] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Arnd Bergmann
The enic driver relies on the CONFIG_CPUMASK_OFFSTACK feature to dynamically allocate a struct member, but this is normally intended for local variables. Building with clang, I get a warning for a few locations that check the address of the cpumask_var_t: drivers/net/ethernet/cisco/enic/enic_main