Re: [PATCH] e1000e: fix debugging printout code

2007-10-15 Thread Kok, Auke
Joe Perches wrote: > On Mon, 2007-10-15 at 09:20 -0700, Kok, Auke wrote: >>> Instead the fix should be for the 2 existing bugs on macro: >>> o Comma after KERN_DEBUG >>> o Semicolon in macro >> will push a patch, thanks. > > Perhaps you could fix this one too? > > $ grep -P -r --include=*.[ch] "\

Re: [PATCH] e1000e: fix debugging printout code

2007-10-15 Thread Joe Perches
On Mon, 2007-10-15 at 09:20 -0700, Kok, Auke wrote: > > Instead the fix should be for the 2 existing bugs on macro: > > o Comma after KERN_DEBUG > > o Semicolon in macro > will push a patch, thanks. Perhaps you could fix this one too? $ grep -P -r --include=*.[ch] "\bprintk\s*\(\s*KERN_[A-Z]+\s*\

Re: [PATCH] e1000e: fix debugging printout code

2007-10-15 Thread Kok, Auke
Joe Perches wrote: > On Fri, 2007-10-05 at 13:53 -0400, Jeff Garzik wrote: >>> diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h >>> index 848217a..aa82f1a 100644 >>> --- a/drivers/net/e1000e/hw.h >>> +++ b/drivers/net/e1000e/hw.h >>> @@ -852,7 +852,7 @@ struct e1000_hw { >>> >>> #i

Re: [PATCH] e1000e: fix debugging printout code

2007-10-15 Thread Joe Perches
On Fri, 2007-10-05 at 13:53 -0400, Jeff Garzik wrote: > > diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h > > index 848217a..aa82f1a 100644 > > --- a/drivers/net/e1000e/hw.h > > +++ b/drivers/net/e1000e/hw.h > > @@ -852,7 +852,7 @@ struct e1000_hw { > > > > #ifdef DEBUG > > #defi

Re: [PATCH] e1000e: fix debugging printout code

2007-10-05 Thread Jeff Garzik
Auke Kok wrote: A small bug crawled in the -DDEBUG enabled code. Fix this to properly call the backreference device name. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- drivers/net/e1000e/netdev.c |4 +--- 2 files changed, 2 insertions(+), 4 deletion

Re: [PATCH] e1000e: fix debugging printout code

2007-10-05 Thread Jeff Garzik
Auke Kok wrote: A small bug crawled in the -DDEBUG enabled code. Fix this to properly call the backreference device name. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- drivers/net/e1000e/netdev.c |4 +--- 2 files changed, 2 insertions(+), 4 deletion

[PATCH] e1000e: fix debugging printout code

2007-10-04 Thread Auke Kok
A small bug crawled in the -DDEBUG enabled code. Fix this to properly call the backreference device name. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/hw.h |2 +- drivers/net/e1000e/netdev.c |4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a