Re: [PATCH] e1000e: Fix link status in case of error.

2018-03-01 Thread Alexander Duyck
On Wed, Feb 28, 2018 at 10:40 PM, Benjamin Poirier wrote: > On 2018/02/28 08:48, Alexander Duyck wrote: >> On Tue, Feb 27, 2018 at 9:20 PM, Benjamin Poirier wrote: >> > Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link >> > up"), errors which happen after "get_link_statu

Re: [PATCH] e1000e: Fix link status in case of error.

2018-02-28 Thread Benjamin Poirier
On 2018/02/28 08:48, Alexander Duyck wrote: > On Tue, Feb 27, 2018 at 9:20 PM, Benjamin Poirier wrote: > > Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link > > up"), errors which happen after "get_link_status = false" in the copper > > check_for_link callbacks would be i

Re: [PATCH] e1000e: Fix link status in case of error.

2018-02-28 Thread Jeff Kirsher
On Wed, 2018-02-28 at 14:20 +0900, Benjamin Poirier wrote: > Before commit 19110cfbb34d ("e1000e: Separate signaling for link > check/link > up"), errors which happen after "get_link_status = false" in the > copper > check_for_link callbacks would be ignored and the link considered up. > After > th

Re: [PATCH] e1000e: Fix link status in case of error.

2018-02-28 Thread Alexander Duyck
On Tue, Feb 27, 2018 at 9:20 PM, Benjamin Poirier wrote: > Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link > up"), errors which happen after "get_link_status = false" in the copper > check_for_link callbacks would be ignored and the link considered up. After > that comm

[PATCH] e1000e: Fix link status in case of error.

2018-02-27 Thread Benjamin Poirier
Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link up"), errors which happen after "get_link_status = false" in the copper check_for_link callbacks would be ignored and the link considered up. After that commit, any error implies that the link is down. Since all combination