Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-16 Thread David Rivshin (Allworx)
On Wed, 16 Dec 2015 07:39:16 +0100 Markus Brunner wrote: > On Monday 14 December 2015 13:04:46 David Rivshin wrote: > > On Sat, 12 Dec 2015 16:44:19 +0100 > ... > > > Your patch works fine on my board, which uses MII and dual_emac > > > with a fixed_phy and a real one. > > > > Thanks for checkin

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-15 Thread Markus Brunner
On Monday 14 December 2015 13:04:46 David Rivshin wrote: > On Sat, 12 Dec 2015 16:44:19 +0100 ... > > Your patch works fine on my board, which uses MII and dual_emac with > > a fixed_phy and a real one. > > Thanks for checking. The only dual_emac board I have available is the > EVMSK, which has tw

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-14 Thread David Rivshin (Allworx)
On Sat, 12 Dec 2015 16:44:19 +0100 Markus Brunner wrote: > On Wednesday 09 December 2015 22:31:15 David Rivshin wrote: > ... > > This patch was originally developed in parallel with 1f71e8c96fc6 to > > accomplish the same goal. When I replaced this patch with > > 1f71e8c96fc6, I found that it did

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-12 Thread Markus Brunner
On Wednesday 09 December 2015 22:31:15 David Rivshin wrote: ... > This patch was originally developed in parallel with 1f71e8c96fc6 to > accomplish the same goal. When I replaced this patch with 1f71e8c96fc6, > I found that it did not work on my hardware (which uses RGMII), so I > am submitting thi

[PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-09 Thread David Rivshin (Allworx)
Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add support for fixed-link PHY") used a 'goto no_phy_slave' to skip over the processing of the mutually-exclusive "phy_id" property. Unfortunately that also skipped the "phy-mode" property processing, leaving slave_data->phy_if w