On Tue, Jul 14, 2020 at 1:07 AM -0700
Martin Schiller wrote:
>
> It really seems very strange that this driver seems to contain such
> fundamental errors. I have never used it.
>
> But the explanations and fixes look plausible to me.
Thank you for reviewing this patch, Martin!
Yes, this situatio
On 2020-07-08 21:04, Xie He wrote:
From: David Miller
Date: Wed, Jul 8, 2020 at 10:13 AM -0700
Something's not right, because I find it hard to believe this has been
so fundamentally broken for such a long period of time.
Maybe the drivers all handle things differently, and whilst your
change
On Mon, Jul 13, 2020 at 2:21 PM Eric Dumazet wrote:
>
> It is not clear to me what guarantee we have to have one byte of headroom in
> the skb
> at this point.
>
> You might add to be safe : (as done in lapbeth_data_indication(), but after
> the skb_push() which seems wrong)
>
> if (skb_co
On 7/7/20 9:37 PM, Xie He wrote:
> This driver is not working because of problems of its receiving code.
> This patch fixes it to make it work.
>
> When the driver receives an LAPB frame, it should first pass the frame
> to the LAPB module to process. After processing, the LAPB module passes
>
This email is a detailed explanation of how to test the LAPB drivers,
just in case you have time to check. Thanks!
This email has 4 parts.
1) How to set up "lapbether" links (for comparison)
2) How to set up "x25_asy" links
3) How to test using AF_X25 sockets
4) How to test using AF_PACKET
From: David Miller
Date: Wed, Jul 8, 2020 at 10:13 AM -0700
> Something's not right, because I find it hard to believe this has been
> so fundamentally broken for such a long period of time.
>
> Maybe the drivers all handle things differently, and whilst your change
> might fix some drivers, it wi
From: Xie He
Date: Tue, 7 Jul 2020 21:37:54 -0700
> This driver is not working because of problems of its receiving code.
> This patch fixes it to make it work.
>
> When the driver receives an LAPB frame, it should first pass the frame
> to the LAPB module to process. After processing, the LAPB
This driver is not working because of problems of its receiving code.
This patch fixes it to make it work.
When the driver receives an LAPB frame, it should first pass the frame
to the LAPB module to process. After processing, the LAPB module passes
the data (the packet) back to the driver, the dr
