Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-06 Thread David Miller
From: Xie He Date: Wed, 5 Aug 2020 18:50:40 -0700 > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-06 Thread Xie He
On Thu, Aug 6, 2020 at 12:47 AM Willem de Bruijn wrote: > > Acked-by: Willem de Bruijn > > The in-band signal byte is required, but stripped by lapbeth_xmit. > Subsequent code will prefix additional headers, including an Ethernet > link layer. The extra space needs to be reserved, but not pulled

Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-06 Thread Willem de Bruijn
On Thu, Aug 6, 2020 at 3:51 AM Xie He wrote: > > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the > header

Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-05 Thread Xie He
I'm sorry I forgot to include the "net" prefix again. I remembered "PATCH" but not "net" this time. I'll try to remember both next time. If requested I can resend the patch with the correct prefix. Sorry.

[PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-05 Thread Xie He
1. Added a skb->len check This driver expects upper layers to include a pseudo header of 1 byte when passing down a skb for transmission. This driver will read this 1-byte header. This patch added a skb->len check before reading the header to make sure the header exists. 2. Changed to use needed_