Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-07 Thread Jeff Garzik
Mariusz Kozlowski wrote: Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. Correct, that memset() is superfluous. Ok. Then this should do it. Signed-off-by: Mariusz Koz

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-07 Thread Brian King
Mariusz Kozlowski wrote: Looks like memset() is zeroing wrong nr of bytes. >>> Good catch, however, I think we can just remove this memset altogether >>> since the memory gets allocated via kzalloc. >> Correct, that memset() is superfluous. > > Ok. Then this should do it. Acked-by: Brian

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Mariusz Kozlowski
> >>Looks like memset() is zeroing wrong nr of bytes. > > > > Good catch, however, I think we can just remove this memset altogether > > since the memory gets allocated via kzalloc. > > Correct, that memset() is superfluous. Ok. Then this should do it. Signed-off-by: Mariusz Kozlowski <[EMA

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Jeff Garzik
Brian King wrote: Mariusz Kozlowski wrote: Hello, Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. Correct, that memset() is superfluous. Jeff - To unsubs

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Brian King
Mariusz Kozlowski wrote: > Hello, > > Looks like memset() is zeroing wrong nr of bytes. Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc. -Brian > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/net/i

[PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Mariusz Kozlowski
Hello, Looks like memset() is zeroing wrong nr of bytes. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/ibmveth.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c2007-08-01 08:43:46.0 +0200