it :)
>
> > Subject: [PATCH] devinet: inetdev_init out label moved after RCU assignment
> >
> > inetdev_init out label moved after RCU assignment
> > (final suggestion by Herbert Xu)
> >
> > Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
>
> Thanks
Yeah, sure.
+-DLS
Acked-by: David L Stevens <[EMAIL PROTECTED]>
> Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
>
> ---
>
> diff -Nurp linux-2.6.20-rc3-/net/ipv4/devinet.c
linux-2.6.20-rc3/net/ipv4/devinet.c
> --- linux-2.6.20-rc3-/net/ipv4/devinet.c 2007-01-05 11:53:16
On Fri, Jan 05, 2007 at 10:23:53PM +1100, Herbert Xu wrote:
> On Fri, Jan 05, 2007 at 12:19:10PM +0100, Jarek Poplawski wrote:
> >
> > Why me? (I didn't spoil this!)
>
> You spotted the problem, so it's only fair that you get the credit :)
Strange... It recalls me the army now! (many years ago)
On Fri, Jan 05, 2007 at 12:19:10PM +0100, Jarek Poplawski wrote:
>
> Why me? (I didn't spoil this!)
You spotted the problem, so it's only fair that you get the credit :)
> Subject: [PATCH] devinet: inetdev_init out label moved after RCU assignment
>
> inetdev_init
RCU is engaged unnecessarily.
>
> I agree. The RCU assignment should come before the out label.
> Can you send a patch?
Why me? (I didn't spoil this!)
Cheers,
Jarek P.
PS: should be applied after David's Stevens patch from 2007.01.04
---
Subject: [PATCH] devinet: inetdev_init o
