Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-09-22 Thread Jiri Benc
On Fri, 22 Sep 2006 11:04:32 +0200, Johannes Berg wrote: > This patch changes (hopefully!) all occurrences in d80211 of > list_for_each to list_for_each_entry (and _safe variants where they were > used before). Applied to my tree, thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscr

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-09-22 Thread Johannes Berg
This patch changes (hopefully!) all occurrences in d80211 of list_for_each to list_for_each_entry (and _safe variants where they were used before). Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- This is the respun patch including no locking changes at all. --- wireless-dev.orig/net/d80211/

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-09-21 Thread Jiri Benc
On Thu, 31 Aug 2006 08:58:50 +0200, Johannes Berg wrote: > On Wed, 2006-08-30 at 08:43 -0700, Jouni Malinen wrote: > > Could you please separate cleanup parts (list_for_each changes) from > > functional changes (adding locking) to make it easier to review the > > patch? > > Yeah, I guess I should

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-08-30 Thread Johannes Berg
On Wed, 2006-08-30 at 08:43 -0700, Jouni Malinen wrote: > Could you please separate cleanup parts (list_for_each changes) from > functional changes (adding locking) to make it easier to review the > patch? Yeah, I guess I should do that. > I would prefer not to hold spinlocks when calling regist

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-08-30 Thread Jouni Malinen
On Wed, Aug 30, 2006 at 10:43:39AM +0200, Johannes Berg wrote: > This patch converts uses of list_for_each and list_for_each_safe to > list_for_each_entry and list_for_each_entry_safe respectively where > applicable. It also adds locking in some places though I'm not entirely > sure that I can do i

[PATCH] d80211: use list_for_each_entry{,_safe}

2006-08-30 Thread Johannes Berg
This patch converts uses of list_for_each and list_for_each_safe to list_for_each_entry and list_for_each_entry_safe respectively where applicable. It also adds locking in some places though I'm not entirely sure that I can do it that way (i.e. call ieee80211_key_enable_hwaccel etc. with spinlocks