Re: [PATCH] cxgb3: avoid needless buffer copy for firmware

2015-06-21 Thread David Miller
From: Kees Cook Date: Tue, 16 Jun 2015 15:36:17 -0700 > There's no reason to perform a buffer copy for the firmware name. This > also avoids a (currently impossible with current callers) NULL dereference > if there was no matching firmware. > > Signed-off-by: Kees Cook Applied to net-next, tha

[PATCH] cxgb3: avoid needless buffer copy for firmware

2015-06-16 Thread Kees Cook
There's no reason to perform a buffer copy for the firmware name. This also avoids a (currently impossible with current callers) NULL dereference if there was no matching firmware. Signed-off-by: Kees Cook --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 12 ++-- 1 file changed, 6 i