Re: [PATCH] core: linkwatch should use jiffies64

2006-05-08 Thread Stefan Rompf
Am Montag 08 Mai 2006 08:07 schrieb David S. Miller: > What is so special about what linkwatch is doing such > that it needs this kind of treatment and other similar > pieces or code do not? > > We have all sorts of interfaces such as time_after() et el. > in order to deal with wrapping issues. t

Re: [PATCH] core: linkwatch should use jiffies64

2006-05-07 Thread David S. Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sun, 7 May 2006 12:13:56 +0200 > the linkwatch code can overflow on a jiffies wrap, scheduling > work with a too large delay. If the delay is >0x8000, > internal_add_timer() seems to overflow too, hiding the bug, so > this isn't triggered too easily

[PATCH] core: linkwatch should use jiffies64

2006-05-07 Thread Stefan Rompf
Hi, the linkwatch code can overflow on a jiffies wrap, scheduling work with a too large delay. If the delay is >0x8000, internal_add_timer() seems to overflow too, hiding the bug, so this isn't triggered too easily. Best solution is to use jiffies64 for calculation as these events happen with