Re: [PATCH] can: don't count arbitration lose as an error

2020-12-02 Thread Jeroen Hofstee
Hello Oliver, On 12/2/20 5:22 PM, Oliver Hartkopp wrote: [...] Aborting the current transmission in non single shot mode will get you there and incorrectly report the message as transmitted, but that is not implemented afaik. Ahem, no. If you get there the echo_skb is deleted and the tx_error

Re: [PATCH] can: don't count arbitration lose as an error

2020-12-02 Thread Oliver Hartkopp
Hello Jeroen, On 02.12.20 16:37, Jeroen Hofstee wrote: On 12/2/20 3:35 PM, Oliver Hartkopp wrote: Do we agree that in one-shot mode both the tx_errors and the arbitration_lost counters are increased in the arbitration-lost case? At least this would fit to the Kvaser USB behaviour. I have

Re: [PATCH] can: don't count arbitration lose as an error

2020-12-02 Thread Jeroen Hofstee
Hello Oliver, On 12/2/20 3:35 PM, Oliver Hartkopp wrote: On 27.11.20 12:09, Jeroen Hofstee wrote: On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send

Re: [PATCH] can: don't count arbitration lose as an error

2020-12-02 Thread Oliver Hartkopp
Hi Jeroen, On 27.11.20 12:09, Jeroen Hofstee wrote: On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send and the pending message will be retried later. H

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-30 Thread Marc Kleine-Budde
On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: > On 11/27/20 10:59 AM, Jeroen Hofstee wrote: >> Losing arbitration is normal in a CAN-bus network, it means that a >> higher priority frame is being send and the pending message will be >> retried later. Hence most driver only increment arbitration_lo

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-29 Thread Jeroen Hofstee
Hello Oliver, On 11/28/20 6:23 PM, Oliver Hartkopp wrote: On 27.11.20 12:09, Jeroen Hofstee wrote: Hi, On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is bein

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-28 Thread Oliver Hartkopp
On 27.11.20 12:09, Jeroen Hofstee wrote: Hi, On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send and the pending message will be retried later. Hence

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-27 Thread Jeroen Hofstee
Hello Marc, [...]   What about one shot mode on the sja1000 cores? That is a good question. I guess it will be counted as error by:         if (isrc & IRQ_TI) {             /* transmission buffer released */             if (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT &&                 !(

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-27 Thread Jeroen Hofstee
Hi, On 11/27/20 11:30 AM, Marc Kleine-Budde wrote: On 11/27/20 10:59 AM, Jeroen Hofstee wrote: Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send and the pending message will be retried later. Hence most driver only increment arbitration_lost,

Re: [PATCH] can: don't count arbitration lose as an error

2020-11-27 Thread Marc Kleine-Budde
On 11/27/20 10:59 AM, Jeroen Hofstee wrote: > Losing arbitration is normal in a CAN-bus network, it means that a > higher priority frame is being send and the pending message will be > retried later. Hence most driver only increment arbitration_lost, but > the sja1000 and sun4i driver also incremea

[PATCH] can: don't count arbitration lose as an error

2020-11-27 Thread Jeroen Hofstee
Losing arbitration is normal in a CAN-bus network, it means that a higher priority frame is being send and the pending message will be retried later. Hence most driver only increment arbitration_lost, but the sja1000 and sun4i driver also incremeant tx_error, causing errors to be reported on a norm