Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Thu, 30 Aug 2007 10:48:13 -0600 > On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote: > > Bridge code calls ethtool to get speed. The conversion to using > > only ethtool_ops broke the case of devices without ethtool_ops. > > This is a

Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote: > Bridge code calls ethtool to get speed. The conversion to using > only ethtool_ops broke the case of devices without ethtool_ops. > This is a new regression in 2.6.23. > > Rearranged the switch to a logical order, and use gcc ini

[PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread Stephen Hemminger
Bridge code calls ethtool to get speed. The conversion to using only ethtool_ops broke the case of devices without ethtool_ops. This is a new regression in 2.6.23. Rearranged the switch to a logical order, and use gcc initializer. Ps: speed should have been part of the network device structure fr