Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-03 Thread Andi Kleen
On Fri, Mar 02, 2007 at 08:22:11PM -0800, David Miller wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Date: 03 Mar 2007 03:14:29 +0100 > > > That's pretty common with many x86 server boards because > > they come with two NICs by default but must people only > > plug the cable into one. However t

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-03 Thread Stefan Rompf
Am Freitag, 2. März 2007 22:26 schrieb David Miller: > The DHCP client should only care about a particular interface's > traffic, the one it wants to listen on. Also, a DHCP client should close the socket between address acquisition and renewal. The only interesting events in that period are ope

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-02 Thread Stephen Hemminger
David Miller wrote: From: Andi Kleen <[EMAIL PROTECTED]> Date: 03 Mar 2007 03:14:29 +0100 That's pretty common with many x86 server boards because they come with two NICs by default but must people only plug the cable into one. However the distro installers run DHCP on all. Nope, tha

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: 03 Mar 2007 03:14:29 +0100 > That's pretty common with many x86 server boards because > they come with two NICs by default but must people only > plug the cable into one. However the distro installers > run DHCP on all. Nope, that's not what I've seen t

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-02 Thread Andi Kleen
David Miller <[EMAIL PROTECTED]> writes: > > And in fact that effectively makes the new socket option > pointless, since it doesn't buy us anything since we have > to support the old stuff fully anyways. I don't think it's pointless because it would still allow newer DHCP clients to have less imp

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 28 Feb 2007 17:18:46 -0800 > I was measuring bridging/routing performance and noticed this. > > The current code runs the "all packet" type handlers before calling the > bridge hook. If an application (like some DHCP clients) is using AF_PAC

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-03-01 Thread jamal
On Wed, 2007-28-02 at 23:30 -0800, David Miller wrote: > That would be perfect for new applications. > But we have to support all the old ones, so we're stuck > providing correctly functioning AF_PACKET handling on > all devices, sorry. > It also breaks all the ingress tc code by making that cha

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 28 Feb 2007 23:26:36 -0800 > sounds like a socket option would help, the data is already there. Then > the normal > UDP receive path would work. That would be perfect for new applications. But we have to support all the old ones, so we're s

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Stephen Hemminger
David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 28 Feb 2007 23:04:36 -0800 If an normal application has to use something like raw packet filtering, it seems there is a missing API. I'm loosely following this discussion, but Ben mentions DHCP and I remember l

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 28 Feb 2007 23:04:36 -0800 > If an normal application has to use something like raw packet > filtering, it seems there is a missing API. I'm loosely following this discussion, but Ben mentions DHCP and I remember learning the other month that

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Stephen Hemminger
Ben Greear wrote: Stephen Hemminger wrote: On Wed, 28 Feb 2007 17:28:09 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: I was measuring bridging/routing performance and noticed this. The current code runs the "all packet" type handlers before calling the bridge hoo

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Ben Greear
Stephen Hemminger wrote: On Wed, 28 Feb 2007 17:28:09 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: I was measuring bridging/routing performance and noticed this. The current code runs the "all packet" type handlers before calling the bridge hook. If an applica

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Stephen Hemminger
On Wed, 28 Feb 2007 17:28:09 -0800 Ben Greear <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > I was measuring bridging/routing performance and noticed this. > > > > The current code runs the "all packet" type handlers before calling > > the bridge hook. If an application (like some DHC

Re: [PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Ben Greear
Stephen Hemminger wrote: I was measuring bridging/routing performance and noticed this. The current code runs the "all packet" type handlers before calling the bridge hook. If an application (like some DHCP clients) is using AF_PACKET, this means that each received packet gets run through the B

[PATCH] bridge: avoid ptype_all packet handling

2007-02-28 Thread Stephen Hemminger
I was measuring bridging/routing performance and noticed this. The current code runs the "all packet" type handlers before calling the bridge hook. If an application (like some DHCP clients) is using AF_PACKET, this means that each received packet gets run through the Berkeley Packet Filter code