Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

On Sun, 2021-04-18 at 06:10 +, Kalle Valo wrote: > Colin King wrote: > > > From: Colin Ian King > > > > The calculation of offtune_val seems incorrect, the u16 value in > > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > > shifted 8 places right so that always ends up a

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

Colin King wrote: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the r

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

Colin King writes: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the r

[PATCH] brcmsmac: fix shift on 4 bit masked value

From: Colin Ian King The calculation of offtune_val seems incorrect, the u16 value in pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then shifted 8 places right so that always ends up as a zero result. I believe the intended shift was 4 bits to the right. Fix this. [Note: not test