Re: [PATCH] brcmfmac: initialize variable

2020-09-13 Thread Arend Van Spriel
On September 13, 2020 4:35:44 PM t...@redhat.com wrote: From: Tom Rix clang static analysis flags this problem sdio.c:3265:13: warning: Branch condition evaluates to a garbage value } else if (pending) { ^~~ brcmf_sdio_dcmd_resp_wait() only sets pending to true.

Re: [PATCH] brcmfmac: initialize variable

2020-09-13 Thread Nathan Chancellor
On Sun, Sep 13, 2020 at 07:35:22AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this problem > sdio.c:3265:13: warning: Branch condition evaluates to > a garbage value > } else if (pending) { >^~~ > > brcmf_sdio_dcmd_resp_wait()

[PATCH] brcmfmac: initialize variable

2020-09-13 Thread trix
From: Tom Rix clang static analysis flags this problem sdio.c:3265:13: warning: Branch condition evaluates to a garbage value } else if (pending) { ^~~ brcmf_sdio_dcmd_resp_wait() only sets pending to true. So pending needs to be initialized to false. Fixes: 5b4